[PM-37593] Add OrganizationUserStatusTypeNew - 🪓 Revoked#7666
[PM-37593] Add OrganizationUserStatusTypeNew - 🪓 Revoked#7666sven-bitwarden wants to merge 3 commits into
Conversation
sven-bitwarden
added
needs-qa
ai-review-vnext
🤖 Bitwarden Claude Code ReviewOverall Assessment: APPROVE This PR is Phase 1 scaffolding for the initiative to separate Code Review DetailsNo findings. Reviewer feedback from |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7666 +/- ##
==========================================
+ Coverage 59.98% 64.54% +4.55%
==========================================
Files 2121 2132 +11
Lines 93543 93905 +362
Branches 8301 8341 +40
==========================================
+ Hits 56113 60611 +4498
+ Misses 35450 31219 -4231
- Partials 1980 2075 +95 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mkincaid-bw
left a comment
mkincaid-bw
left a comment
There was a problem hiding this comment.
Couple minor changes
JaredScar
left a comment
JaredScar
left a comment
There was a problem hiding this comment.
Admin Console changes seem fine (only 2 files)
|
@mkincaid-bw updated - thanks for the reminder especially on the views ✌️ |
|
| @@ -0,0 +1,17 @@ | |||
| using Bit.Core.Entities; | |||
|
|
|||
| namespace Bit.Core.Enums; | |||
There was a problem hiding this comment.
This should be in Bit.Core.AdminConsole.Enums. The only reason our current enum isn't is that moving it would trigger code owner review bingo.
This is non-blocking and can be addressed in a later PR.
| public string? ResetPasswordKey { get; set; } | ||
| /// <inheritdoc cref="OrganizationUserStatusType"/> | ||
| public OrganizationUserStatusType Status { get; set; } | ||
| /// <inheritdoc cref="OrganizationUserStatusTypeNew"/> |
There was a problem hiding this comment.
This could do with some more explicit documentation at this stage. e.g.
This is not fully in use yet and should not be used outside the restore/revoke flows.
It is only used to back up the Status before revoking a user, and restore
the user to the correct status later. It should be null if the user is not revoked.
(also non-blocking)
4 participants
🎟️ Tracking
PM-37593
📔 Objective
This PR implements part of Phase 1 of the initiative to separate Revoked from OrganizationUserStatusType.
The overall initiative will have us creating a new home for OrganizationUserStatusType (sans Revoked), populating it for revokes and checking it first for restores, moving all organization user status type checks to account for revoked now being a separate field, and then cleaning up.